[v1alpha2]Remove redundant code about status and fix bug of invalid job status #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pengyu Chen <chenpengyu@caicloud.io>
|
I will take a look. While we prefer to do one thing in one PR. Thus next time please open separate PRs for separate issues. |
codeflitting
changed the title
|
/assign @gaocegege |
gaocegege
reviewed
Jul 4, 2018
| @@ -431,6 +193,11 @@ func isFailed(status tfv1alpha2.TFJobStatus) bool { | |||
| // If the condition that we are about to add already exists | |||
| // and has the same status and reason then we are not going to update. | |||
| func setCondition(status *tfv1alpha2.TFJobStatus, condition tfv1alpha2.TFJobCondition) { | |||
| //Do nothing if condition Failed | |||
| if isFailed(*status) { | |||
There was a problem hiding this comment.
Besides this, I think we should set the condition Running to false when the job is succeeded or failed.
|
/retest |
Signed-off-by: Pengyu Chen <chenpengyu@caicloud.io>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
jetmuffin
pushed a commit
to jetmuffin/tf-operator
that referenced
this pull request
Jul 9, 2018
…ob status (kubeflow#715) * Remove redundant code about status Signed-off-by: Pengyu Chen <chenpengyu@caicloud.io> * fix bug of invalid job status Signed-off-by: Pengyu Chen <chenpengyu@caicloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #713
fix #712
/cc @gaocegege
Signed-off-by: Pengyu Chen chenpengyu@caicloud.io
This change is