Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a log function issue #724

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Fix a log function issue #724

merged 1 commit into from
Jul 13, 2018

Conversation

lovejoy
Copy link
Contributor

@lovejoy lovejoy commented Jul 12, 2018

Info should be Infof


This change is Reviewable

Info should be Infof
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@coveralls
Copy link

coveralls commented Jul 12, 2018

Coverage Status

Coverage remained the same at 57.349% when pulling b3592b2 on lovejoy:patch-1 into 3fba4db on kubeflow:master.

@lovejoy
Copy link
Contributor Author

lovejoy commented Jul 12, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@lovejoy
Copy link
Contributor Author

lovejoy commented Jul 12, 2018

/assign @gaocegege

@gaocegege
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lovejoy
Copy link
Contributor Author

lovejoy commented Jul 13, 2018

@gaocegege seems somebody need to remove needs-ok-to-test label ?

@gaocegege
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot merged commit a0c09f2 into kubeflow:master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants