Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate api information in OpenAPI model and register types to scheme #733

Merged
merged 3 commits into from
Jul 17, 2018

Conversation

jetmuffin
Copy link
Contributor

@jetmuffin jetmuffin commented Jul 17, 2018

The Install function will be used when generating OpenAPI specification for Java/Python client. See my last PR for more detail #719 .

Signed-off-by: JetMuffin mofeng.cj@alibaba-inc.com


This change is Reviewable

Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
@TravisBuddy
Copy link

Travis tests have failed

Hey @jetmuffin,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

gometalinter --config=linter_config.json --vendor ./...
pkg/apis/tensorflow/v1alpha2/install.go:1::warning: file is not goimported (goimports)

3rd Build

gometalinter --config=linter_config.json --vendor ./...
pkg/apis/tensorflow/v1alpha2/install.go:1::warning: file is not goimported (goimports)

travis_time:end:015076c8:start=1531819928738968933,finish=1531820074953840826,duration=146214871893

@coveralls
Copy link

coveralls commented Jul 17, 2018

Coverage Status

Coverage decreased (-0.3%) to 56.923% when pulling 6faaee9 on JetMuffin:install into bb60bfa on kubeflow:master.

Signed-off-by: JetMuffin <mofeng.cj@alibaba-inc.com>
@jetmuffin jetmuffin changed the title Add a function to register api group and add type to scheme Generate api information in OpenAPI model and register types to scheme Jul 17, 2018
@ScorpioCPH
Copy link
Member

/ok-to-test

@gaocegege
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9e396a4 into kubeflow:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants