Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not proper log message #734

Merged
merged 1 commit into from
Jul 18, 2018
Merged

fix not proper log message #734

merged 1 commit into from
Jul 18, 2018

Conversation

ChanYiLin
Copy link
Member

@ChanYiLin ChanYiLin commented Jul 17, 2018

this fix the issue in #727
If the err is errNotExists, then we can simply print the information and return directly.


This change is Reviewable

@ChanYiLin
Copy link
Member Author

/assign @gaocegege
could you help me to check, thanks!

@coveralls
Copy link

coveralls commented Jul 17, 2018

Coverage Status

Coverage increased (+12.9%) to 69.836% when pulling aa357c6 on ChanYiLin:master into 9e396a4 on kubeflow:master.

@gaocegege
Copy link
Member

/lgtm
/ok-to-test
/approve
Thanks for your contribution!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 46808ba into kubeflow:master Jul 18, 2018
@lovejoy
Copy link
Contributor

lovejoy commented Jul 18, 2018

have you test this ?I tried to fix this like your code,but may cause some other problem.
大哥你试过吗,我本来想的也是这么改,但是貌似会有其他问题呢

@gaocegege
Copy link
Member

@lovejoy Could you please explain what the problem is

@lovejoy
Copy link
Contributor

lovejoy commented Jul 18, 2018

All right ,I found the problem is i did a fix in function getTFJobFromKey look likes this code. But that have something wrong.
好吧,是我改的那个有问题。看起来像这个但不是。

@gaocegege
Copy link
Member

@lovejoy Gotcha. Thanks for the issue 😄

@ChanYiLin
Copy link
Member Author

I didn't change any code in the function getTFJobFromKey.
Actually getTFJobFromKey return errNotExists when the tfjob was deleted.
So I just add this condition into processNextWorkItem() function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants