Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming TFJobController to TFController #777

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Renaming TFJobController to TFController #777

merged 1 commit into from
Aug 17, 2018

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Aug 14, 2018

TFJobController is renamed to TFController for consistency.
From #776 (comment)


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.957% when pulling 84e1d20 on johnugeorge:rename into 44c5382 on kubeflow:master.

@johnugeorge
Copy link
Member Author

/retest

1 similar comment
@johnugeorge
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member Author

@gaocegege @ScorpioCPH

Copy link
Member

@ScorpioCPH ScorpioCPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@johnugeorge
Copy link
Member Author

johnugeorge commented Aug 17, 2018

\cc @gaocegege @jlewi

@gaocegege
Copy link
Member

/lgtm
/approve

Thanks for your contribution!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5fa4dca into kubeflow:master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants