Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Avoid triggering reconcileTFJobs if no TFJob update (#796)" #805

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Aug 30, 2018

Close #800
This reverts commit 554d750.


This change is Reviewable

@gaocegege
Copy link
Member Author

/assign @jian-he @jlewi

@k8s-ci-robot
Copy link

@gaocegege: GitHub didn't allow me to assign the following users: jian-he.

Note that only kubeflow members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @jian-he @jlewi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnugeorge
Copy link
Member

/lgtm

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 58.282% when pulling 91ef1ca on gaocegege:revert into e63ea46 on kubeflow:master.

@gaocegege
Copy link
Member Author

/retest

1 similar comment
@johnugeorge
Copy link
Member

/retest

@gaocegege
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1e8af2e into kubeflow:master Aug 30, 2018
@jian-he
Copy link
Contributor

jian-he commented Aug 31, 2018

sorry for late response. I commented the rationale for this change. Please see if it makes sense.

@gaocegege gaocegege deleted the revert branch September 1, 2018 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants