Adding to Owners #808
Merged
Adding to Owners #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaocegege
reviewed
Aug 30, 2018
OWNERS
Outdated
| @@ -14,3 +15,4 @@ reviewers: | |||
| - lluunn | |||
| - willb | |||
| - yph152 | |||
| - johnugeorge | |||
There was a problem hiding this comment.
Glad to get your help!
I think we could add approver, no need to add both approver and reviewer.
gaocegege
reviewed
Aug 30, 2018
OWNERS
Outdated
| @@ -4,6 +4,7 @@ approvers: | |||
| - jlewi | |||
| - ScorpioCPH | |||
| - wbuchwalter | |||
| - johnugeorge | |||
There was a problem hiding this comment.
Sorry I missed one thing. please keep the order. We need to put your name before ScorpioCPH
There was a problem hiding this comment.
Thanks for pointing out. Done
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since operator implementations are closely related, I will port required PRs to pytorch repo and vice versa.
/assign @gaocegege @jlewi
This change is