Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor restructuring #812

Merged
merged 2 commits into from
Aug 31, 2018
Merged

Minor restructuring #812

merged 2 commits into from
Aug 31, 2018

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Aug 30, 2018 •
edited by jlewi
Loading

  1. Renaming tfcontroller to tensorflow (it is already in controller folder). Naming is now consistent with the Pytorch repo
  2. Removed GetTotalReplicas from Controller interface as it is not necessary for all operators.

This change is Reviewable

@johnugeorge
Copy link
Member Author

/assign @gaocegege

@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 61.654% when pulling 96ee188 on johnugeorge:minor into 52f8609 on kubeflow:master.

@coveralls
Copy link

coveralls commented Aug 30, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 58.242% when pulling 96ee188 on johnugeorge:minor into 52f8609 on kubeflow:master.

gaocegege
gaocegege reviewed Aug 31, 2018
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1bc8425 into kubeflow:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@ChanYiLin ChanYiLin Awaiting requested review from ChanYiLin

@yph152 yph152 Awaiting requested review from yph152

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnugeorge @coveralls @k8s-ci-robot @gaocegege