Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused functions #827

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Cleanup unused functions #827

merged 1 commit into from
Sep 12, 2018

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Sep 12, 2018

The unused functions are removed. K8sutil package must contain only k8s utility functions and has to be independent of tf code. It can be then shared across operators


This change is Reviewable

@gaocegege
Copy link
Member

/lgtm

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 57.104% when pulling 3019b6a on johnugeorge:cleanup into 6af5924 on kubeflow:master.

@johnugeorge
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit b026d2b into kubeflow:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants