-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update releaser to use Argo. #400
Comments
…403) Update our E2E test to use ksonnet not helm to deploy As part of this we have a slightl loss in test coverage because our helm test provides some verification that our python tests don't. Create a releasing environment for workflows that has parameters set as needed to build using our release cluster. Related to #400 Use Argo for releases #373 Improve our test harness
I don't think it makes sense to update the cron job/releaser that regularly rebuilds the TFJob operator image. We should just delete that code right now since its no longer used. Instead of updating that, we should think about how to continuosly buiild docker image images as needed as part of our release process for Kubeflow ksonnet packages. Per kubeflow/testing#40 right now we would just manually run the Argo workflow to build the TFJob image before cutting the ksonnet release. |
SGTM, I think we should establish the continuous deployment process to build and publish docker image. |
Our release infra is pretty much a mirror of our test infra except more restricted (e.g. we don't expose the Argo UI.) We also need to grant the service account permissions on projects used as GCR registries. Update the instructions for setting up our test infra. Provide gcloud commands for some steps. Related to kubeflow/trainer#400
Our releaser for tf-operator is currently broken.
Due to various issues.
I think we should refactor this to be an Argo workflow that builds ontop of our E2E workflows so that we validate the image as part of a release.
We could start with what our E2E tests do and then if the tests pass push the image to an appropriate registry with the appropriate tag.
The text was updated successfully, but these errors were encountered: