set completion time on success (#554)

kubeflow · Apr 24, 2018 · 60d25c4 · 60d25c4
1 parent 33bc774
commit 60d25c4
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/pkg/controller.v2/controller_pod.go b/pkg/controller.v2/controller_pod.go
@@ -57,6 +57,8 @@ func (tc *TFJobController) reconcilePods(
 	// All workers are succeeded, leave a succeeded condition.
 	if expected == 0 && rtype == tfv1alpha2.TFReplicaTypeWorker {
 		msg := fmt.Sprintf("TFJob %s is successfully completed.", tfjob.Name)
+		now := metav1.Now()
+		tfjob.Status.CompletionTime = &now
 		err := tc.updateTFJobConditions(tfjob, tfv1alpha2.TFJobSucceeded, tfJobSucceededReason, msg)
 		if err != nil {
 			loggerForTFJob(tfjob).Infof("Append tfjob condition error: %v", err)