fix ci

kubeflow · Oct 21, 2022 · f27e611 · f27e611
1 parent cf1c3f5
commit f27e611
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 17 deletions.
diff --git a/manifests/base/crds/kubeflow.org_paddlejobs.yaml b/manifests/base/crds/kubeflow.org_paddlejobs.yaml
@@ -44,6 +44,7 @@ spec:
             description: Specification of the desired state of the PaddleJob.
             properties:
               elasticPolicy:
+                description: ElasticPolicy holds the elastic policy for paddle job.
                 properties:
                   maxReplicas:
                     description: upper limit for the number of pods that can be set
@@ -52,6 +53,8 @@ spec:
                     format: int32
                     type: integer
                   maxRestarts:
+                    description: MaxRestarts is the limit for restart times of pods
+                      in elastic mode.
                     format: int32
                     type: integer
                   metrics:

diff --git a/pkg/apis/kubeflow.org/v1/paddlepaddle_validation_test.go b/pkg/apis/kubeflow.org/v1/paddlepaddle_validation_test.go
@@ -69,23 +69,6 @@ func TestValidateV1PaddleJobSpec(t *testing.T) {
 				},
 			},
 		},
-		{
-			PaddleReplicaSpecs: map[commonv1.ReplicaType]*commonv1.ReplicaSpec{
-				PaddleJobReplicaTypeMaster: {
-					Replicas: pointer.Int32(2),
-					Template: v1.PodTemplateSpec{
-						Spec: v1.PodSpec{
-							Containers: []v1.Container{
-								{
-									Name:  "paddle",
-									Image: "gcr.io/kubeflow-ci/paddle-dist-mnist_test:1.0",
-								},
-							},
-						},
-					},
-				},
-			},
-		},
 	}
 	for _, c := range testCases {
 		err := ValidateV1PaddleJobSpec(&c)