Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest tag on gcr.io is not up to date #116

Closed
sozercan opened this issue Nov 2, 2017 · 4 comments
Closed

Latest tag on gcr.io is not up to date #116

sozercan opened this issue Nov 2, 2017 · 4 comments

Comments

@sozercan
Copy link
Contributor

sozercan commented Nov 2, 2017

Helm chart now contains latest tag but latest on gcr.io is pretty old :)

https://console.cloud.google.com/gcr/images/tf-on-k8s-dogfood/GLOBAL/tf_operator@sha256:5a58039ab631aee6b370da21be5be6a841b757b08e7873e19b42ffbc71032ad3/details/info
@jlewi
Copy link
Contributor

jlewi commented Nov 3, 2017

We need to update the GCB workflow in py/release.py to apply the latest tag.

@jlewi
Copy link
Contributor

jlewi commented Nov 3, 2017

Actually looks like gcloud supports add a tag to an image. I think adding the "latest" tag as a separate step is better because this way we can run tests before promoting an image to latest.

@jlewi jlewi mentioned this issue Nov 3, 2017
Merged
@jlewi jlewi closed this as completed in #119 Nov 3, 2017
jlewi added a commit that referenced this issue Nov 3, 2017
@jlewi
Tag docker images with "latest". (#119)
2e34034 
Fixes #116
@jlewi jlewi reopened this Nov 3, 2017
@jlewi
Copy link
Contributor

jlewi commented Nov 3, 2017

Will close this after verifying that newly built images are tagged latest.

@jlewi
Copy link
Contributor

jlewi commented Nov 3, 2017

Confirmed. Latest tag is now applied to the latest build

@jlewi jlewi closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlewi @sozercan