Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support failurePolicy like successPolicy #1170

Closed
gaocegege opened this issue Jun 11, 2020 · 10 comments
Closed

[feature] Support failurePolicy like successPolicy #1170

gaocegege opened this issue Jun 11, 2020 · 10 comments

Comments

@gaocegege
Copy link
Member

We should support custom failPolicy like successPolicy.

For example, when there is one master, 4 workers. When 4 workers are failed and 1 master is running, it is hard to say that the job is failed.

Thus we need to have a way to let users tell us when we should think the job is failed.

/cc @ChanYiLin

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/operator 0.64
feature 0.98

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@terrytangyuan
Copy link
Member

terrytangyuan commented Jun 11, 2020

Maybe failurePolicy to be more consistent?

@gaocegege
Copy link
Member Author

SGTM

@ChanYiLin
Copy link
Member

also SGTM

@pingsutw
Copy link
Member

/assign

@stale
Copy link

stale bot commented Sep 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@terrytangyuan
Copy link
Member

/lifecycle freeze

@stale stale bot removed the lifecycle/stale label Sep 13, 2020
@stale
Copy link

stale bot commented Dec 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@terrytangyuan
Copy link
Member

/lifecycle freeze

@stale stale bot removed the lifecycle/stale label Dec 12, 2020
@terrytangyuan terrytangyuan changed the title [feature] Support failedPolicy like successPolicy [feature] Support failurePolicy like successPolicy Dec 12, 2020
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Jun 2, 2021
@stale stale bot closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants