Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not introduce k8s.io/kube-openapi@master #1174

Closed
pingsutw opened this issue Jun 16, 2020 · 7 comments
Closed

Could not introduce k8s.io/kube-openapi@master #1174

pingsutw opened this issue Jun 16, 2020 · 7 comments

Comments

@pingsutw
Copy link
Member

pingsutw commented Jun 16, 2020

How to reproduce?

cd ${GOPATH}/src/github.com/kubeflow
git clone git@github.com:kubeflow/tf-operator.git
dep ensure

Error message

Solving failure: Could not introduce k8s.io/kube-openapi@master, as it requires package k8s.io/klog/v2 from k8s.io/klog, but in version v2.2.0 that package is missing.

I've done with #1170, but I can't generate openapi_generated.go

$ ./hack/update-codegen.sh

# output
enerating deepcopy funcs
Generating clientset for tensorflow:v1 at github.com/kubeflow/tf-operator/pkg/client/clientset
Generating listers for tensorflow:v1 at github.com/kubeflow/tf-operator/pkg/client/listers
Generating informers for tensorflow:v1 at github.com/kubeflow/tf-operator/pkg/client/informers
Generating defaulters for tensorflow/v1
Generating OpenAPI specification for tensorflow/v1
./hack/update-codegen.sh: line 45: /home/dslab/go/bin/openapi-gen: No such file or director
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/operator 0.53
kind/bug 0.83

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@gaocegege
Copy link
Member

Maybe we can use go mod instead soon. Maybe after #1171

@ChanYiLin
Copy link
Member

@pingsutw
We have already migrated to go mod, you can refer to this PR #1144.
So instead of using dep ensure, you have to use go mod download to download the dependencies.

@gaocegege I think we have to update the developer_guide.md to reflect the change

@pingsutw
Copy link
Member Author

@ChanYiLin Thanks, I will update my PR ASAP.

@ChanYiLin
Copy link
Member

BTW, for the openapi_generated, you have to install openapi-gen (from https://github.com/kubernetes/kube-openapi) first like defaulter-gen in your {GO_PATH}/bin

@stale
Copy link

stale bot commented Sep 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this as completed Sep 26, 2020
@ChanYiLin
Copy link
Member

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants