[sdk]: Replace TableLogger component in the SDK for better support with ipykernel>=6.x
#1446
Comments
alembiewski
changed the title
TableLogger component in the SDK for better support with ipykernel 6.xTableLogger component in the SDK for better support with ipykernel>=6.x
|
/help |
|
@alembiewski: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
To add some further activity to stave off stalebot - another reason to switch is that while |
Closes kubeflow#1446. This removes the dependency on `table-logger`. None of the various alternatives mentioned in that issues were drop-in replacements, so given the simplicity of the use case here the dependency is replaced with a small class utilizing `str.format`. Note that the class was written without referring to the `table-logger` source at all, which would be a license violation. I confirmed that you can now run the sample notebook https://github.com/kubeflow/training-operator/blob/6523d8d2b7a27f1140a05971843cc4da7523694f/sdk/python/examples/kubeflow-tfjob-sdk.ipynb in modern IPython.
Closes #1446. This removes the dependency on `table-logger`. None of the various alternatives mentioned in that issues were drop-in replacements, so given the simplicity of the use case here the dependency is replaced with a small class utilizing `str.format`. Note that the class was written without referring to the `table-logger` source at all, which would be a license violation. I confirmed that you can now run the sample notebook https://github.com/kubeflow/training-operator/blob/6523d8d2b7a27f1140a05971843cc4da7523694f/sdk/python/examples/kubeflow-tfjob-sdk.ipynb in modern IPython.
The current version of
table-loggerpackage doesn't work withipykernel >= 6.0.0due to the recent changes in the latter, making writing string as bytes no longer supported.We need to exclude
table-loggerdependency from the SDK and replace theTableLoggercomponent used in*_job_watch.pyfor reporting job events with a more generic approach, making the watcher work with the neweripykernelversions. Some suggestions include, but not limited to:str.formatcould work for SDK use-case as wellThe original issue and more details can be found here: #1445
The text was updated successfully, but these errors were encountered: