Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes versions to be supported in the next training operator release #1803

Closed
Tracked by #1809
tenzen-y opened this issue May 7, 2023 · 15 comments · Fixed by #1834
Closed
Tracked by #1809

Kubernetes versions to be supported in the next training operator release #1803

tenzen-y opened this issue May 7, 2023 · 15 comments · Fixed by #1834
Assignees

Comments

@tenzen-y
Copy link
Member

tenzen-y commented May 7, 2023

Currently, we support 3 K8s versions, such as v1.23, v1.24, and v1.25.

However, v1.23 has already reached EoL, and v1.24 will reach EoL on 2023-07-28.

So we can support v1.24-v1.26 or v1.25-v1.27 in the next training operator release.

ref: https://kubernetes.io/releases/

WDYT? @kubeflow/wg-training-leads @zw0610 @kuizhiqing

@tenzen-y tenzen-y changed the title Support Kubernetes verions in next training operator release Kubernetes versions to be supported in the next training operator release May 7, 2023
@tenzen-y
Copy link
Member Author

tenzen-y commented May 7, 2023

I prefer v1.25-v1.27.

@terrytangyuan
Copy link
Member

No objection but if it's low effort to keep 1.24 support, it would be great.

@tenzen-y
Copy link
Member Author

tenzen-y commented May 7, 2023

No objection but if it's low effort to keep 1.24 support, it would be great.

If we stop supporting 1.24, we can add CEL validation (#1708). I believe that adding validations makes increase UX.

@terrytangyuan
Copy link
Member

If that's the only benefit, I'd suggest holding off on dropping 1.24 support since many production systems are still running on that.

@tenzen-y
Copy link
Member Author

tenzen-y commented May 7, 2023

If that's the only benefit, I'd suggest holding off on dropping 1.24 support since many production systems are still running on that.

It sounds good to me, and I'm ok with keeping to support 1.24. But probably, we can't support the scheduler-plugins integration in v1.24 because of #1769.

In the next release, we support essential features of the training operator in v1.24-v1.26, although we don't support the scheduler plugin integration in v1.24.

@tenzen-y
Copy link
Member Author

tenzen-y commented May 7, 2023

This means users can upgrade the training operator to the next one in K8s v1.24 only if they don't use the scheduler-plugins integration.

If they want to use the latest training operator with the scheduler plugins integration, they must use K8s v1.25-v1.26.

@terrytangyuan
Copy link
Member

Ok I am fine with dropping v1.24 support.

@tenzen-y
Copy link
Member Author

tenzen-y commented May 8, 2023

Ok I am fine with dropping v1.24 support.

Thank you!
@ OWNERS Let me know if someone would like to support v1.24 :)

@johnugeorge
Copy link
Member

IMO, supporting 1.24 would be tough. I am proposing to keep 1.25 as the minimum k8s version. The community is proposing for supporting till 1.27 for the next KF release

Ref: kubeflow/manifests#2450 (comment)

@tenzen-y
Copy link
Member Author

IMO, supporting 1.24 would be tough. I am proposing to keep 1.25 as the minimum k8s version. The community is proposing for supporting till 1.27 for the next KF release

Ref: kubeflow/manifests#2450 (comment)

Thank you for letting us know!

@johnugeorge
Copy link
Member

johnugeorge commented May 17, 2023

We can support 1.25, 1.26 and 1.27 in v1.7.0 release for being consistent

@tenzen-y
Copy link
Member Author

/assign

In the first step, I'll try to bump k8s version to v1.26.

@tenzen-y
Copy link
Member Author

I will create a PR to upgrade k8s to v1.27 after #1769 is done.

@tenzen-y
Copy link
Member Author

tenzen-y commented Jun 8, 2023

I found that k8s v1.24 is blocking other tasks.

@tenzen-y
Copy link
Member Author

tenzen-y commented Jun 8, 2023

So I will upgrade k8s version, first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants