Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to mark prow job as failed if any tests fail #315

Closed
jlewi opened this issue Jan 15, 2018 · 0 comments
Closed

Need to mark prow job as failed if any tests fail #315

jlewi opened this issue Jan 15, 2018 · 0 comments
Labels
area/testing

Comments

@jlewi
Copy link
Contributor

jlewi commented Jan 15, 2018 •
edited
Loading

Our prow jobs are being marked as successful even though some of our tests failed (as indicated by the junit files).

We should add a step to our test pipeline to read all the junit XML files and mark the prow job as failed by setting status failed in finished.json.
This was referenced Jan 15, 2018
Closed
Merged
Merged
jlewi added a commit that referenced this issue Jan 17, 2018
@jlewi
Take test failures into account when setting prow job status (#319)
04425d9 
When setting prow job status, we want to look at the junit files and see if there were any test failures. Otherwise the k8s robot will report the tests as succeeding even when there were failures.

Fix #315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlewi