Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runner.py needs to create build-log.txt with stdout/stderr of test #82

Closed
jlewi opened this issue Oct 25, 2017 · 0 comments · Fixed by #91
Closed

runner.py needs to create build-log.txt with stdout/stderr of test #82

jlewi opened this issue Oct 25, 2017 · 0 comments · Fixed by #91
Labels
area/testing

Comments

@jlewi
Copy link
Contributor

jlewi commented Oct 25, 2017

See GCS Layout

We should be creating build-log.txt with stdout/stderr from the test.

Ideally we should capture output of bootstrap.py as well. We can probably just add a logging handler
that appends logs of bootstrap.py and runner.py to a file.
This was referenced Oct 25, 2017
Closed
Closed
Merged
@jlewi jlewi closed this as completed in #91 Oct 27, 2017
jlewi added a commit that referenced this issue Oct 27, 2017
@jlewi
Add python lint check to travis and fix python lint issues (#91)
16fc3d0 
Add a python lint check
   Partial fix to #53

Capture stdout/stderr of the test and upload to GCS so we have a proper build log that outlives the pod lifetime.
  Fixes #82

* Run autopep8 on all py files.

* Fix python lint issues

* pylintrc was copied from kuberntes/test-infra

* Disable import-error message since some py files run inside containers
which will have different libraries then the machine running the lint check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add python lint check to travis and fix python lint issues jlewi/k8s
1 participant
@jlewi