-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix api reader issue #1551
fix api reader issue #1551
Conversation
/hold for more comment |
Pull Request Test Coverage Report for Build 2003571271
💛 - Coveralls |
That's awesome! After this pr is merged, the MPIJob panic bug when GetJobFromAPIClient could be solved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reuse APIReader from manager makes more sense.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, Jeffwan, terrytangyuan, zw0610 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What this PR does / why we need it:
Function
GetJobFromAPIClient
is used to get the kubeflow Job from APIServer directly without cache. However, the contemporary implementation is hard to understand and will panic when CacheReader is called: https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/client/split.go#L130The
Manager
in controller-runtime offersAPIReader
which does the work to get job from APIServer.This PR changes how
GetJobFromAPIClient
to get job from APIServer by adding APIReader to Reconcilers.