add pytorch mpi mxnet xgboost clientset and update doc #1586

41tair · 2022-05-05T12:44:38Z

What this PR does / why we need it:
add pytorch mpi mxnet xgboost clientset and fix the confict

Which issue(s) this PR fixes
Fixes #1501

aws-kf-ci-bot · 2022-05-05T12:44:51Z

Hi @41tair. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gaocegege · 2022-05-06T02:52:51Z

pkg/apis/tensorflow/v1/doc.go

@@ -16,5 +16,5 @@
 // +k8s:openapi-gen=true

 // Package v1 is the v1 version of the API.
-// +groupName=kubeflow.org
+// +groupName=tensorflow.kubeflow.org


It may be a block change /cc @kubeflow/wg-training-leads @zw0610

Is it auto-generated or manually? I believe we should keep the group name, even in the documentation.

Is it auto-generated or manually? I believe we should keep the group name, even in the documentation.

This is generated manually, and the code-generator does not generate clientset.This is a workaround.More info in #1501

gaocegege · 2022-05-06T02:56:49Z

/ok-to-test

41tair · 2022-05-11T10:32:13Z

is there any update? Change the api structure like

#1501
Like other projects, we change the hierarchy to /pkg/apis//<ml_framework_x>_type.go where they all span in same directory meaning they are in same subgroup, then when generating clientset informer, they will be in the same package.

or use this pr modification?

zw0610 · 2022-05-12T10:55:28Z

is there any update? Change the api structure like

#1501
Like other projects, we change the hierarchy to /pkg/apis//<ml_framework_x>_type.go where they all span in same directory meaning they are in same subgroup, then when generating clientset informer, they will be in the same package.

or use this pr modification?

I prefer changing the hierarchy to /pkg/apis/v1/<ml_framework_x>_type.go, which is more universal.

Windfarer · 2022-05-18T15:06:54Z

go.mod

@@ -1,4 +1,4 @@
-module github.com/kubeflow/training-operator
+module github.com/41tair/training-operator


this modification should be cancelled

aws-kf-ci-bot · 2022-05-19T07:41:26Z

@41tair: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
kubeflow-training-operator-presubmit	`2c43247`	link	`/test kubeflow-training-operator-presubmit`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

johnugeorge · 2022-06-05T18:02:15Z

Ref: #1592

johnugeorge · 2022-06-05T18:11:29Z

@41tair Can you please update?

tenzen-y · 2022-06-05T18:49:10Z

@41tair I would like to include this feature next training-operator release. Do you have any time to work on this PR?
If you have only a little time to work on this, I'd like to create another PR.

Thank you for your contribution!

41tair · 2022-06-06T04:40:28Z

@41tair I would like to include this feature next training-operator release. Do you have any time to work on this PR?

If you have only a little time to work on this, I'd like to create another PR.

Thank you for your contribution!

I'd like update this pr before Friday,if it will be before this release.

tenzen-y · 2022-06-06T07:08:54Z

@41tair I would like to include this feature next training-operator release. Do you have any time to work on this PR?
If you have only a little time to work on this, I'd like to create another PR.
Thank you for your contribution!

I'd like update this pr before Friday,if it will be before this release.

@41tair Thanks for your response.
We need to merge to the master branch by June 15th to include this feature in the next release.

google-oss-prow · 2022-06-11T08:07:00Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 41tair

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow bot added the size/XXL label May 5, 2022

aws-kf-ci-bot added the needs-ok-to-test label May 5, 2022

google-oss-prow bot requested review from jinchihe, terrytangyuan and zw0610 May 5, 2022 12:45

gaocegege reviewed May 6, 2022

View reviewed changes

aws-kf-ci-bot added ok-to-test and removed needs-ok-to-test labels May 6, 2022

Windfarer reviewed May 18, 2022

View reviewed changes

41tair closed this Jun 11, 2022

41tair force-pushed the master branch from 2c43247 to a579f63 Compare June 11, 2022 08:06

google-oss-prow bot added size/XS and removed size/XXL labels Jun 11, 2022

41tair mentioned this pull request Jun 11, 2022

add pytorch mpi mxnet xgboost clientset and update doc #1611

Closed

tenzen-y mentioned this pull request Jun 11, 2022

Add clientset for MPIJob, PytorchJob, MXJob, and XGBoostJob #1610

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add pytorch mpi mxnet xgboost clientset and update doc #1586

add pytorch mpi mxnet xgboost clientset and update doc #1586

41tair commented May 5, 2022 •

edited

Loading

aws-kf-ci-bot commented May 5, 2022

gaocegege May 6, 2022

zw0610 May 6, 2022

41tair May 6, 2022

gaocegege commented May 6, 2022

41tair commented May 11, 2022 •

edited

Loading

zw0610 commented May 12, 2022

Windfarer May 18, 2022

aws-kf-ci-bot commented May 19, 2022

johnugeorge commented Jun 5, 2022

johnugeorge commented Jun 5, 2022

tenzen-y commented Jun 5, 2022 •

edited

Loading

41tair commented Jun 6, 2022

tenzen-y commented Jun 6, 2022 •

edited

Loading

google-oss-prow bot commented Jun 11, 2022

		@@ -1,4 +1,4 @@
		module github.com/kubeflow/training-operator
		module github.com/41tair/training-operator

add pytorch mpi mxnet xgboost clientset and update doc #1586

add pytorch mpi mxnet xgboost clientset and update doc #1586

Conversation

41tair commented May 5, 2022 • edited Loading

aws-kf-ci-bot commented May 5, 2022

gaocegege May 6, 2022

Choose a reason for hiding this comment

zw0610 May 6, 2022

Choose a reason for hiding this comment

41tair May 6, 2022

Choose a reason for hiding this comment

gaocegege commented May 6, 2022

41tair commented May 11, 2022 • edited Loading

zw0610 commented May 12, 2022

Windfarer May 18, 2022

Choose a reason for hiding this comment

aws-kf-ci-bot commented May 19, 2022

johnugeorge commented Jun 5, 2022

johnugeorge commented Jun 5, 2022

tenzen-y commented Jun 5, 2022 • edited Loading

41tair commented Jun 6, 2022

tenzen-y commented Jun 6, 2022 • edited Loading

google-oss-prow bot commented Jun 11, 2022

41tair commented May 5, 2022 •

edited

Loading

41tair commented May 11, 2022 •

edited

Loading

tenzen-y commented Jun 5, 2022 •

edited

Loading

tenzen-y commented Jun 6, 2022 •

edited

Loading