Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop action on first fail #1595

Merged
merged 1 commit into from
May 23, 2022
Merged

chore: stop action on first fail #1595

merged 1 commit into from
May 23, 2022

Conversation

jasonliu747
Copy link
Member

What this PR does / why we need it:
Currently, github action won't stop even though there is an error during make step. Adding a && to make sure github action abort on first fail.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2365103720

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 37.322%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 77.9%
Totals Coverage Status
Change from base Build 2313052087: 0.05%
Covered Lines: 2311
Relevant Lines: 6192

💛 - Coveralls

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 👍

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 23, 2022
@google-oss-prow google-oss-prow bot merged commit 0ad86c4 into kubeflow:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants