-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a generic logger instead of the nil logger on dependent update #1680
Make a generic logger instead of the nil logger on dependent update #1680
Conversation
Signed-off-by: Peng Gao <peng.gao.dut@gmail.com>
Pull Request Test Coverage Report for Build 3392042555
💛 - Coveralls |
This resolved the issue scheduling TFJobs with volcano for me! |
Signed-off-by: Peng Gao <peng.gao.dut@gmail.com>
This pr fixes the previous wrong pr #1666 and uses generic functions for the podgroup callbacks. This pr also adds a test for the XXXFunc which only handles pod and service objects instead of other generic objects. @johnugeorge @D0m021ng @Crazybean-lwb |
Signed-off-by: Peng Gao <peng.gao.dut@gmail.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggaaooppeenngg, johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Dynamic watcher ref: #1688 |
Signed-off-by: Peng Gao peng.gao.dut@gmail.com
What this PR does / why we need it:
Make a temporary logger for generic object instead of being nil.
Which issue(s) this PR fixes
Fixes #1679 #1678
Checklist: