Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mac M1 compatible Dockerfile and bump TF version #1700

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

terrytangyuan
Copy link
Member

The TF image does not work on Mac M1. Switching to use Python base image and install TF from there. Also bumped TF versions.

Verified that the example works.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Dec 15, 2022

Pull Request Test Coverage Report for Build 3706744342

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 39.455%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 77.67%
Totals Coverage Status
Change from base Build 3655920262: -0.1%
Covered Lines: 2681
Relevant Lines: 6795

💛 - Coveralls

@johnugeorge
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 19, 2022
@google-oss-prow google-oss-prow bot merged commit 52eb491 into master Dec 19, 2022
@terrytangyuan terrytangyuan deleted the terrytangyuan-patch-1 branch December 19, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants