Run E2E with various Python versions to verify Python SDK #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Pull Request Test Coverage Report for Build 3999588857
💛 - Coveralls |
johnugeorge
reviewed
Jan 24, 2023
| # TODO (tenzen-y): Add volcano. | ||
| gang-scheduler-name: ["none", "scheduler-plugins"] | ||
| include: | ||
| - kubernetes-version: v1.23.12 |
There was a problem hiding this comment.
Is this matrix set randomly?
There was a problem hiding this comment.
It looks confused for a new reader. I can't think of a better way if we want to avoid running all combinations. Can you add a comment for clarity?
There was a problem hiding this comment.
@johnugeorge Updated. PTAL.
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com
What this PR does / why we need it:
As with kubeflow/katib#2092, run E2E with various Python versions to verify Python SDK.
/assign @andreyvelich @johnugeorge @terrytangyuan
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: