Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e testing support volcano gang-scheduler #1831

Merged
merged 1 commit into from
Jun 17, 2023
Merged

e2e testing support volcano gang-scheduler #1831

merged 1 commit into from
Jun 17, 2023

Conversation

lowang-bh
Copy link
Member

add e2e test of volcano gang-schedule

  1. put patching gang-scheduler-name before installing gang-scheduler-plugin
  2. split version of volcano.sh/apis without relationship of k8s

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1736

Checklist:

  • Docs included if any changes are user facing

@lowang-bh lowang-bh mentioned this pull request Jun 13, 2023
Merged
@coveralls
Copy link

coveralls commented Jun 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5286272665

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 33.75%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 58.19%
Totals Coverage Status
Change from base Build 5281977738: 0.0%
Covered Lines: 3320
Relevant Lines: 9837
💛 - Coveralls

@tenzen-y
Copy link
Member

@lowang-bh Is this PR working in progress?

@lowang-bh
Copy link
Member Author

@lowang-bh Is this PR working in progress?

Need to fix the failed CI.

@tenzen-y
Copy link
Member

/hold

@google-oss-prow google-oss-prow bot added size/L and removed size/S labels Jun 15, 2023
@lowang-bh
Copy link
Member Author

MR #1828 go first, plz.

tenzen-y
tenzen-y reviewed Jun 15, 2023
View reviewed changes
scripts/gha/setup-training-operator.sh Outdated Show resolved Hide resolved
scripts/gha/setup-training-operator.sh Outdated Show resolved Hide resolved
scripts/gha/setup-training-operator.sh Outdated Show resolved Hide resolved
@johnugeorge
Copy link
Member

Please rebase as well. #1828 is merged

@google-oss-prow google-oss-prow bot added size/S and removed size/L labels Jun 16, 2023
@lowang-bh
Copy link
Member Author

Please rebase as well. #1828 is merged

Done

@lowang-bh
e2e testing support volcano gang-scheduler
52a0eb5 
put patching gang-scheduler-name before installing gang-scheduler-plugin

Signed-off-by: lowang-bh <lhui_wang@163.com>
tenzen-y
tenzen-y reviewed Jun 16, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lowang-bh Thanks!
/lgtm
/assign @johnugeorge

@google-oss-prow google-oss-prow bot added the lgtm label Jun 16, 2023
@tenzen-y
Copy link
Member

/hold cancel

@lowang-bh Can you check failed test?

https://github.com/kubeflow/training-operator/actions/runs/5286272660/jobs/9565543144?pr=1831

@lowang-bh
Copy link
Member Author

https://github.com/kubeflow/training-operator/actions/runs/5286272660/jobs/9565543144?pr=1831

I need to fetch volcano webhook controller log when CI failed.

@tenzen-y
Copy link
Member

tenzen-y commented Jun 16, 2023 •
edited
Loading

https://github.com/kubeflow/training-operator/actions/runs/5286272660/jobs/9565543144?pr=1831

I need to fetch volcano webhook controller log when CI failed.

Can you reproduce this error on your local?

@johnugeorge
Copy link
Member

Succeeded after retry. Seems to be a flaky test?

@tenzen-y
Copy link
Member

tenzen-y commented Jun 16, 2023 •
edited
Loading

Succeeded after retry. Seems to be a flaky test?

@johnugeorge I see. @lowang-bh Can you create an issue to keep tracking the flaky test?

@lowang-bh lowang-bh mentioned this pull request Jun 17, 2023
Closed
@lowang-bh
Copy link
Member Author

@lowang-bh Can you create an issue to keep tracking the flaky test?

done.

@johnugeorge
Copy link
Member

Thanks @lowang-bh

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, lowang-bh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 15ea54b into kubeflow:master Jun 17, 2023
@lowang-bh lowang-bh deleted the volcano-e2e branch June 17, 2023 06:56
This was referenced Jun 17, 2023
Merged
Closed
@lowang-bh lowang-bh mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@johnugeorge johnugeorge johnugeorge left review comments

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees

@johnugeorge johnugeorge

@tenzen-y tenzen-y

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lowang-bh @coveralls @tenzen-y @johnugeorge