Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error check that never occurs #1868

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
Because the result of commonutil.UpdateJobConditions() is always nil, we shouldn't return an error.

follow-up: #1859

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Jul 21, 2023

Pull Request Test Coverage Report for Build 5624194705

  • 25 of 54 (46.3%) changed or added relevant lines in 10 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.5%) to 40.316%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/mpi/mpijob_controller.go 4 5 80.0%
pkg/controller.v1/common/pod.go 0 3 0.0%
pkg/controller.v1/mxnet/mxjob_controller.go 2 5 40.0%
pkg/controller.v1/pytorch/pytorchjob_controller.go 4 7 57.14%
pkg/controller.v1/common/job.go 0 4 0.0%
pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go 3 7 42.86%
pkg/controller.v1/xgboost/xgboostjob_controller.go 2 7 28.57%
pkg/reconciler.v1/common/job.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/common/job.go 1 6.15%
pkg/controller.v1/common/pod.go 1 2.83%
pkg/reconciler.v1/common/job.go 1 8.64%
pkg/controller.v1/mxnet/mxjob_controller.go 6 61.92%
Totals Coverage Status
Change from base Build 5623533920: 0.5%
Covered Lines: 3859
Relevant Lines: 9572

💛 - Coveralls

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Copy link

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 497e759 into kubeflow:master Jul 21, 2023
@tenzen-y tenzen-y deleted the clean-up-status-util branch July 21, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants