-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error check that never occurs #1868
Fix error check that never occurs #1868
Conversation
Pull Request Test Coverage Report for Build 5624194705
💛 - Coveralls |
1dd112e
to
427b883
Compare
427b883
to
1c1348e
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
1c1348e
to
82e7aba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Because the result of
commonutil.UpdateJobConditions()
is always nil, we shouldn't return an error.follow-up: #1859
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: