Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a community hosted image in MXJob E2E #1928

Merged

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Oct 5, 2023

What this PR does / why we need it:
I replaced the MXJob E2E image with a community-hosted image. Also, I fixed the bug in a MXJob example.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Oct 5, 2023

Pull Request Test Coverage Report for Build 6423232289

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 42.802%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/pytorch/pytorchjob_controller.go 4 67.42%
pkg/controller.v1/xgboost/xgboostjob_controller.go 6 60.39%
Totals Coverage Status
Change from base Build 6418619650: -0.05%
Covered Lines: 3746
Relevant Lines: 8752

💛 - Coveralls

@tenzen-y
Copy link
Member Author

tenzen-y commented Oct 5, 2023

/assign @johnugeorge @terrytangyuan @kuizhiqing

@terrytangyuan
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 5, 2023
@google-oss-prow google-oss-prow bot merged commit 95f2553 into kubeflow:master Oct 5, 2023
31 checks passed
@tenzen-y tenzen-y deleted the use-community-hosted-mxnet-image branch October 6, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants