Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update k8s dependency to stable version #230

Merged
merged 4 commits into from
Dec 18, 2017
Merged

update k8s dependency to stable version #230

merged 4 commits into from
Dec 18, 2017

Conversation

wackxu
Copy link
Contributor

@wackxu wackxu commented Dec 17, 2017

#215 is working on refactor the TfJob to use K8s libraries, before we merge that, we should first to update k8s dependency to stable version.

  1. now the dependency for k8s is not the release version and when I work on Refactor the TfJob to use K8s libraries  #215, the code-generator is something wrong because the dependency is too old and I switch the version to kubernetes 1.8.X.
  2. Once this is get merged, Refactor the TfJob to use K8s libraries  #215 can go on.
  3. After Refactor the TfJob to use K8s libraries  #215 get merged, then I can begin refactor the controller

@jlewi Any thoughts? can you take a look at this?


This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@k8s-ci-robot
Copy link

Hi @wackxu. Thanks for your PR.

I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlewi
Copy link
Contributor

jlewi commented Dec 18, 2017

Overall looks good; just one minor question about a new dependency.


Reviewed 17 of 18 files at r1.
Review status: 17 of 18 files reviewed at latest revision, 1 unresolved discussion.


glide.lock, line 78 at r1 (raw file):

- name: github.com/pborman/uuid
  version: a97ce2ca70fa5a848076093f05e639a89ca34d06
- name: github.com/peterbourgon/diskv

Do you know why this dependency got added? Do we use it directly or is it a transitive dependency?


Comments from Reviewable

@jlewi
Copy link
Contributor

jlewi commented Dec 18, 2017

/ok-to-test

@wackxu
Copy link
Contributor Author

wackxu commented Dec 18, 2017

@jlewi That is a transitive dependency and it is auto added when I run glide update. And I resolve the conflicts just now and then I run glide-cleanup to remove some unused dependency.

"k8s.io/client-go/tools/record"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR generated LGTM, small nits should format imported package:

import (
	"flag"
	"fmt"
	"os"
	"os/signal"
	"runtime"
	"time"
	"io/ioutil"

	log "github.com/golang/glog"
	"github.com/ghodss/yaml"
	"github.com/tensorflow/k8s/pkg/controller"
	"github.com/tensorflow/k8s/pkg/util"
	"github.com/tensorflow/k8s/pkg/util/k8sutil"
	"github.com/tensorflow/k8s/pkg/spec"
	"github.com/tensorflow/k8s/version"

	election "k8s.io/client-go/tools/leaderelection"
	"k8s.io/client-go/tools/leaderelection/resourcelock"
	"k8s.io/client-go/tools/record"
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zjj2wry Thanks for your review, Done

@jlewi jlewi merged commit 5ada743 into kubeflow:master Dec 18, 2017
@wackxu wackxu deleted the upven branch March 1, 2018 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants