Fix the junit XML file format. #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test failures weren't being properly reported to gubernator because we had the wrong XML format. We need to use a nested failure tag and specify the message inside the tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failures weren't being properly reported to gubernator because we had
the wrong XML format. We need to use a nested failure tag and specify the
message inside the tag.
Gubernator still reports the test as succeeded even if there were failures (I think we need to exit with now zero exit code from the prow job). I'll fix that in a follow on PR. In the meantime this allows us to see test failures if we click through to the gubernator dashboard.
Related to Gaps in test coverage #280
This change is