Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: Fix the code changed in #486 #497

Merged
merged 1 commit into from
Mar 23, 2018
Merged

pkg: Fix the code changed in #486 #497

merged 1 commit into from
Mar 23, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Mar 23, 2018

Use code-gen to regenerate the code to eliminate changes in pkg/client.

Signed-off-by: Ce Gao gaoce@caicloud.io


This change is Reviewable

@gaocegege
Copy link
Member Author

I'd appreciate if anyone is interested in #426

@gaocegege
Copy link
Member Author

/assign @ScorpioCPH

@coveralls
Copy link

coveralls commented Mar 23, 2018

Coverage Status

Coverage remained the same at 45.418% when pulling 632d3cc on gaocegege:fix into d944f75 on kubeflow:master.

Copy link
Member

@ScorpioCPH ScorpioCPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these changes are auto-generated.
/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScorpioCPH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Ce Gao <gaoce@caicloud.io>
@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 23, 2018
@k8s-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link

@gaocegege: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-tf-operator-presubmit 632d3cc link /test kubeflow-tf-operator-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gaocegege
Copy link
Member Author

googleapiclient.errors.HttpError: <HttpError 403 when requesting https://container.googleapis.com/v1/projects/kubeflow-ci/zones/us-east1-d/clusters?alt=json returned "Insufficient regional quota to satisfy request for resource: "DISKS_TOTAL_GB". The request requires '100.0' and is short '4.0'. The regional quota is '4096.0' with '96.0' available.">

The cluster has no enough resource to run tests, and I will merge it manually since it is generated by code-gen and it should have no issues in CI test.

@gaocegege gaocegege merged commit eec56b5 into kubeflow:master Mar 23, 2018
@gaocegege gaocegege deleted the fix branch March 23, 2018 06:54
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants