Add proper error handling for deploying the tests. #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add retries for ksonnet errors because it looks like with 0.11 we start having problems because GPU and non GPU tests both try to add the environment * If the ksonnet environment already exists this will cause an error; we should keep going. Fix kubeflow#640
* Fix lint
|
/assign @gaocegege |
|
What do the yaml files do? Are they checked-in on intentionally? |
|
@ankushagarwal Removed the YAML files; Looks like they were spurious; probably the result of updating the test app in another branch. |
|
/lgtm Thanks for fixing this! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal, jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
yph152
pushed a commit
to yph152/tf-operator
that referenced
this pull request
Jun 18, 2018
* Add proper error handling for deploying the tests. * Add retries for ksonnet errors because it looks like with 0.11 we start having problems because GPU and non GPU tests both try to add the environment * If the ksonnet environment already exists this will cause an error; we should keep going. Fix kubeflow#640 * * Add retries to test_runner * Fix lint * Fix lint. * Remove YAML files.
jetmuffin
pushed a commit
to jetmuffin/tf-operator
that referenced
this pull request
Jul 9, 2018
* Add proper error handling for deploying the tests. * Add retries for ksonnet errors because it looks like with 0.11 we start having problems because GPU and non GPU tests both try to add the environment * If the ksonnet environment already exists this will cause an error; we should keep going. Fix kubeflow#640 * * Add retries to test_runner * Fix lint * Fix lint. * Remove YAML files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add retries for ksonnet errors because it looks like with 0.11 we start
having problems because GPU and non GPU tests both try to add the environment
If the ksonnet environment already exists this will cause an error;
we should keep going.
Use kubeflow/testing/py/util.py rather than the util module in tf-operator
In waiting for pod deletes; don't print an error when pods not found because that's expected and the error just causes confusion.
Fix #640
This change is