Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Move test util to separate package #666

Merged
merged 7 commits into from
Jun 15, 2018
Merged

*: Move test util to separate package #666

merged 7 commits into from
Jun 15, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jun 14, 2018 •
edited by jlewi
Loading

Move the util functions about test to a separate package.

Signed-off-by: Ce Gao gaoce@caicloud.io

This change is Reviewable

@gaocegege
*: Refactor
31977ed 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
travis: Remove util from coverage test
34c32cc 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
test: Add copyright holder
b70de2a 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
*: Fix errors
1a0d9fb 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@kubeflow kubeflow deleted a comment from TravisBuddy Jun 14, 2018
@kubeflow kubeflow deleted a comment from TravisBuddy Jun 14, 2018
@TravisBuddy
Copy link

Travis tests have failed

Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

gometalinter --config=linter_config.json --vendor ./... 
pkg/util/testutil/pod.go:81:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:85:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/service.go:59:21:warning: error return value not checked (serviceIndexer.Add(service)) (errcheck)
pkg/util/testutil/pod.go:30:2:warning: unused variable or constant controllerName (varcheck)
pkg/util/testutil/pod.go:73:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:77:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go" 
=== RUN   TestAddAccelertor
--- PASS: TestAddAccelertor (0.00s)
PASS
coverage: 2.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper	0.076s
=== RUN   TestSetDefaults_TFJob
--- PASS: TestSetDefaults_TFJob (0.00s)
PASS
coverage: 1.8% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1	0.047s
=== RUN   TestSetDefaultTFJob
--- PASS: TestSetDefaultTFJob (0.00s)
PASS
coverage: 2.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2	0.062s
=== RUN   TestValidate
--- PASS: TestValidate (0.00s)
PASS
coverage: 2.9% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation	0.052s
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/controller	[no test files]
=== RUN   TestAddPod
--- PASS: TestAddPod (0.31s)
=== RUN   TestClusterSpec
--- PASS: TestClusterSpec (0.00s)
=== RUN   TestRestartPolicy
--- PASS: TestRestartPolicy (0.00s)
=== RUN   TestExitCode
--- PASS: TestExitCode (0.00s)
=== RUN   TestAddService
--- PASS: TestAddService (0.30s)
=== RUN   TestFailed
--- PASS: TestFailed (0.00s)
=== RUN   TestStatus
--- PASS: TestStatus (0.00s)
=== RUN   TestNormalPath
--- PASS: TestNormalPath (0.01s)
=== RUN   TestRun
--- PASS: TestRun (0.50s)
=== RUN   TestAddTFJob
--- PASS: TestAddTFJob (0.30s)
=== RUN   TestCopyLabelsAndAnnotation
--- PASS: TestCopyLabelsAndAnnotation (0.00s)
=== RUN   TestCreatePods
--- PASS: TestCreatePods (0.01s)
=== RUN   TestCreateService
--- PASS: TestCreateService (0.00s)
=== RUN   TestCreateServicesWithControllerRef
--- PASS: TestCreateServicesWithControllerRef (0.00s)
=== RUN   TestClaimServices
--- PASS: TestClaimServices (0.00s)
PASS
coverage: 33.0% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/controller.v2	1.519s
exit status 1: warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/informers/externalversions
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/controller
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/controller.v2
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/trainer
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util/k8sutil
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util/signals
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util/testutil
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util/train
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/util/unstructured
warning: no packages being tested depend on github.com/kubeflow/tf-operator/pkg/version
# github.com/kubeflow/tf-operator/pkg/generator
import cycle not allowed in test
package github.com/kubeflow/tf-operator/pkg/generator (test)
	imports github.com/kubeflow/tf-operator/pkg/generator

FAIL	github.com/kubeflow/tf-operator/pkg/generator [setup failed]

3rd Build

gometalinter --config=linter_config.json --vendor ./... 
pkg/util/testutil/pod.go:30:2:warning: unused variable or constant controllerName (varcheck)
pkg/util/testutil/pod.go:73:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:77:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:81:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:85:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/service.go:59:21:warning: error return value not checked (serviceIndexer.Add(service)) (errcheck)

travis_time:end:10488766:start=1528980786100132690,finish=1528980920615018385,duration=134514885695
goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go" 
=== RUN   TestAddAccelertor
--- PASS: TestAddAccelertor (0.00s)
PASS
coverage: 8.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper	0.034s	coverage: 8.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
=== RUN   TestSetDefaults_TFJob
--- PASS: TestSetDefaults_TFJob (0.00s)
PASS
coverage: 6.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1	0.032s	coverage: 6.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
=== RUN   TestSetDefaultTFJob
--- PASS: TestSetDefaultTFJob (0.00s)
PASS
coverage: 13.7% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2	0.031s	coverage: 13.7% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
=== RUN   TestValidate
--- PASS: TestValidate (0.00s)
PASS
coverage: 14.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation	0.032s	coverage: 14.2% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2	[no test files]
?   	github.com/kubeflow/tf-operator/pkg/controller	[no test files]
=== RUN   TestAddPod
time="2018-06-14T12:55:44Z" level=info msg="Starting TFJob controller"
time="2018-06-14T12:55:44Z" level=info msg="Waiting for informer caches to sync"
time="2018-06-14T12:55:44Z" level=info msg="Starting 1 workers"
time="2018-06-14T12:55:44Z" level=info msg="Started workers"
--- PASS: TestAddPod (0.31s)
=== RUN   TestClusterSpec
--- PASS: TestClusterSpec (0.00s)
=== RUN   TestRestartPolicy
--- PASS: TestRestartPolicy (0.00s)
=== RUN   TestExitCode
time="2018-06-14T12:55:44Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:44Z" level=info msg="Need to restart the pod: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:44Z" level=info msg="need to create new service: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:44Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (370.489µs)"
--- PASS: TestExitCode (0.00s)
=== RUN   TestAddService
time="2018-06-14T12:55:44Z" level=info msg="Starting TFJob controller"
time="2018-06-14T12:55:44Z" level=info msg="Waiting for informer caches to sync"
time="2018-06-14T12:55:44Z" level=info msg="Shutting down workers"
time="2018-06-14T12:55:44Z" level=info msg="Starting TFJob controller"
time="2018-06-14T12:55:44Z" level=info msg="Waiting for informer caches to sync"
time="2018-06-14T12:55:44Z" level=info msg="Starting 1 workers"
time="2018-06-14T12:55:44Z" level=info msg="Started workers"
time="2018-06-14T12:55:44Z" level=info msg="Shutting down workers"
time="2018-06-14T12:55:45Z" level=info msg="Starting 1 workers"
time="2018-06-14T12:55:45Z" level=info msg="Started workers"
--- PASS: TestAddService (0.30s)
=== RUN   TestFailed
--- PASS: TestFailed (0.00s)
=== RUN   TestStatus
--- PASS: TestStatus (0.00s)
=== RUN   TestNormalPath
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (416.429µs)"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (256.835µs)"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (172.654µs)"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: ps-0" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: ps-0" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-1" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-2" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-1" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-2" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (559.154µs)"
time="2018-06-14T12:55:45Z" level=info msg="Shutting down workers"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (328.147µs)"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-2" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-2" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (698.631µs)"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: ps-1" job=default/test-tfjob replica-type=ps uid=
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-3" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (717.285µs)"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (348.91µs)"
--- PASS: TestNormalPath (0.01s)
=== RUN   TestRun
time="2018-06-14T12:55:45Z" level=info msg="Starting TFJob controller"
time="2018-06-14T12:55:45Z" level=info msg="Waiting for informer caches to sync"
time="2018-06-14T12:55:45Z" level=info msg="Starting 1 workers"
time="2018-06-14T12:55:45Z" level=info msg="Started workers"
time="2018-06-14T12:55:45Z" level=info msg="Shutting down workers"
--- PASS: TestRun (0.50s)
=== RUN   TestAddTFJob
time="2018-06-14T12:55:45Z" level=info msg="Starting TFJob controller"
time="2018-06-14T12:55:45Z" level=info msg="Waiting for informer caches to sync"
time="2018-06-14T12:55:45Z" level=info msg="TFJob test-tfjob is created."
time="2018-06-14T12:55:45Z" level=info msg="Starting 1 workers"
time="2018-06-14T12:55:45Z" level=info msg="Started workers"
--- PASS: TestAddTFJob (0.30s)
=== RUN   TestCopyLabelsAndAnnotation
time="2018-06-14T12:55:45Z" level=info msg="Shutting down workers"
time="2018-06-14T12:55:45Z" level=info msg="Starting TFJob controller"
time="2018-06-14T12:55:45Z" level=info msg="Waiting for informer caches to sync"
time="2018-06-14T12:55:45Z" level=info msg="Reconcile TFJobs test-tfjob"
time="2018-06-14T12:55:45Z" level=info msg="Need to create new pod: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="need to create new service: worker-0" job=default/test-tfjob replica-type=worker uid=
time="2018-06-14T12:55:45Z" level=info msg="Finished syncing tfjob \"default/test-tfjob\" (372.414µs)"
--- PASS: TestCopyLabelsAndAnnotation (0.00s)
=== RUN   TestCreatePods
time="2018-06-14T12:55:45Z" level=info msg="Starting 1 workers"
time="2018-06-14T12:55:45Z" level=info msg="Started workers"
time="2018-06-14T12:55:45Z" level=info msg="Shutting down workers"
--- PASS: TestCreatePods (0.01s)
=== RUN   TestCreateService
--- PASS: TestCreateService (0.00s)
=== RUN   TestCreateServicesWithControllerRef
--- PASS: TestCreateServicesWithControllerRef (0.00s)
=== RUN   TestClaimServices
--- PASS: TestClaimServices (0.00s)
PASS
coverage: 46.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
ok  	github.com/kubeflow/tf-operator/pkg/controller.v2	1.499s	coverage: 46.1% of statements in github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1, github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2, github.com/kubeflow/tf-operator/pkg/controller, github.com/kubeflow/tf-operator/pkg/controller.v2, github.com/kubeflow/tf-operator/pkg/generator, github.com/kubeflow/tf-operator/pkg/trainer, github.com/kubeflow/tf-operator/pkg/util, github.com/kubeflow/tf-operator/pkg/util/k8sutil, github.com/kubeflow/tf-operator/pkg/util/signals, github.com/kubeflow/tf-operator/pkg/util/testutil, github.com/kubeflow/tf-operator/pkg/util/train, github.com/kubeflow/tf-operator/pkg/util/unstructured, github.com/kubeflow/tf-operator/pkg/version
exit status 1: warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/apis/tensorflow/helper
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/apis/tensorflow/validation
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/fake
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/scheme
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha1/fake
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/clientset/versioned/typed/kubeflow/v1alpha2/fake
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/informers/externalversions
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/internalinterfaces
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha1
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/informers/externalversions/kubeflow/v1alpha2
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha1
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/client/listers/kubeflow/v1alpha2
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/controller
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/controller.v2
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/trainer
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util/k8sutil
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util/signals
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util/testutil
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util/train
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/util/unstructured
warning: no packages being tested depend on matches for pattern github.com/kubeflow/tf-operator/pkg/version
# github.com/kubeflow/tf-operator/pkg/generator
import cycle not allowed in test
package github.com/kubeflow/tf-operator/pkg/generator (test)
	imports github.com/kubeflow/tf-operator/pkg/generator

FAIL	github.com/kubeflow/tf-operator/pkg/generator [setup failed]


travis_time:end:00d5f902:start=1528980920620676889,finish=1528980946056338911,duration=25435662022

@gaocegege
generator: Fix test
38afe10 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
pods: Add error handler
15453bf 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@coveralls
Copy link

coveralls commented Jun 15, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 57.745% when pulling 224ad6f on gaocegege:refactor into f8fa47e on kubeflow:master.

@TravisBuddy
Copy link

Travis tests have failed

Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

3rd Build

gometalinter --config=linter_config.json --vendor ./... 
pkg/util/testutil/service.go:59:21:warning: error return value not checked (serviceIndexer.Add(service)) (errcheck)
pkg/util/testutil/pod.go:30:2:warning: unused variable or constant controllerName (varcheck)
pkg/util/testutil/pod.go:73:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:77:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:81:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)
pkg/util/testutil/pod.go:85:17:warning: error return value not checked (podIndexer.Add(pod)) (errcheck)

travis_time:end:114c09f6:start=1529031899150653153,finish=1529031999953872851,duration=100803219698

@gaocegege gaocegege mentioned this pull request Jun 15, 2018
Merged
@gaocegege
testutil: Fix linting errors
224ad6f 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@kubeflow kubeflow deleted a comment from TravisBuddy Jun 15, 2018
@gaocegege
Copy link
Member Author

/assign @jlewi

It is to ease the maintenance.

@gaocegege
Copy link
Member Author

I am merging it since it blocks #672

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 050a717 into kubeflow:master Jun 15, 2018
@gaocegege gaocegege deleted the refactor branch June 15, 2018 04:42
@gaocegege gaocegege mentioned this pull request Jun 15, 2018
Closed
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
@gaocegege
*: Move test util to separate package (kubeflow#666)
6aae93d 
* *: Refactor

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* travis: Remove util from coverage test

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* test: Add copyright holder

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* *: Fix errors

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* generator: Fix test

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* pods: Add error handler

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* testutil: Fix linting errors

Signed-off-by: Ce Gao <gaoce@caicloud.io>
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
@gaocegege @k8s-ci-robot
*: Move test util to separate package (kubeflow#666)
f2bbf41 
* *: Refactor

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* travis: Remove util from coverage test

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* test: Add copyright holder

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* *: Fix errors

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* generator: Fix test

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* pods: Add error handler

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* testutil: Fix linting errors

Signed-off-by: Ce Gao <gaoce@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimexist jimexist Awaiting requested review from jimexist

@willb willb Awaiting requested review from willb

Assignees

@jlewi jlewi

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaocegege @TravisBuddy @coveralls @k8s-ci-robot @jlewi