[v1alpha2] Add more validation of TFJobSpec #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeflitting
changed the title
|
/assign @gaocegege |
gaocegege
reviewed
Jul 2, 2018
| @@ -21,6 +21,7 @@ import ( | |||
| tfv1 "github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1" | |||
| tfv2 "github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2" | |||
| "github.com/kubeflow/tf-operator/pkg/util" | |||
| log "github.com/sirupsen/logrus" | |||
There was a problem hiding this comment.
Please put the import in the middle of the group.
import (
"errors"
"fmt"
log "github.com/sirupsen/logrus"
tfv1 "github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha1"
tfv2 "github.com/kubeflow/tf-operator/pkg/apis/tensorflow/v1alpha2"
"github.com/kubeflow/tf-operator/pkg/util"
)| @@ -32,6 +33,12 @@ func ValidateAlphaTwoTFJobSpec(c *tfv2.TFJobSpec) error { | |||
| if value == nil || len(value.Template.Spec.Containers) == 0 { | |||
| return fmt.Errorf("TFJobSpec is not valid") | |||
| } | |||
| for _, container := range value.Template.Spec.Containers { | |||
| if container.Image == "" { | |||
| log.Warn("Container was missing image") | |||
There was a problem hiding this comment.
s/Container was missing image/Image is undefined in the container
There was a problem hiding this comment.
Please check there is one container with name tensorflow, too.
gaocegege
changed the title
Signed-off-by: Pengyu Chen <chenpengyu@caicloud.io>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetmuffin
pushed a commit
to jetmuffin/tf-operator
that referenced
this pull request
Jul 9, 2018
Signed-off-by: Pengyu Chen <chenpengyu@caicloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #707
/cc gaocegege
Signed-off-by: Pengyu Chen chenpengyu@caicloud.io
This change is