Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test fix: None type check #735

Merged
merged 1 commit into from
Jul 18, 2018
Merged

test fix: None type check #735

merged 1 commit into from
Jul 18, 2018

Conversation

kunmingg
Copy link
Contributor

@kunmingg kunmingg commented Jul 17, 2018

Saw:

conditions = [c.get("type", "") for c in all_conditions]
TypeError: 'NoneType' object is not iterable

from e2e test.


This change is Reviewable

@kunmingg
Copy link
Contributor Author

@ankushagarwal
@lluunn

@lluunn
Copy link
Contributor

lluunn commented Jul 18, 2018

/lgtm
/approve

@coveralls
Copy link

coveralls commented Jul 18, 2018

Coverage Status

Coverage remained the same at 56.923% when pulling 02ac8c2 on kunmingg:master into 9e396a4 on kubeflow:master.

@kunmingg
Copy link
Contributor Author

/retest

1 similar comment
@gaocegege
Copy link
Member

/retest

@gaocegege
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 21f3ea4 into kubeflow:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants