Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve meta information in log messages to make it easier to debug jobs #765

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Improve meta information in log messages to make it easier to debug jobs #765

merged 2 commits into from
Aug 1, 2018

Commits on Jul 30, 2018

  1. Improve meta information in log messages to make it easier to debug j… 

    …obs.

* Use <namespace>.<name> as opposed to <namespace>/<name>; the former
  is more consistent with K8s style.

* Add functions for constructing loggers for the pod and unstructured meta
  information. This will allow us to appropriately tag a number of log
  messages with meta information.

* Update a bunch of log messages which weren't logging info with
  appropriate meta information.

* Make json log formatting the default; this was the case for v1.
  json logging should be the default because otherwise we lose the meta
  information in the logs. With json logs its always possible to filter/reformat
  the log entries if you don't care about the metainformation.

Related to:
  kubeflow#24 Use logrus
  kubeflow#635
    @jlewi
    jlewi committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    1442adf View commit details
    Browse the repository at this point in the history

  2. Fix lint by running; goimports.

    @jlewi
    jlewi committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    d5fccf2 View commit details
    Browse the repository at this point in the history