Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for evaluator #895

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

DeliangFan
Copy link
Contributor

@DeliangFan DeliangFan commented Dec 18, 2018

Add validation for evaluator so that the number of evaluator
should no more than 1.

Close #894


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @DeliangFan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DeliangFan
Copy link
Contributor Author

/assign @johnugeorge

@coveralls
Copy link

coveralls commented Dec 18, 2018

Coverage Status

Coverage increased (+0.2%) to 65.011% when pulling c10b155 on DeliangFan:validation-for-evaluator into 2fde284 on kubeflow:master.

@johnugeorge
Copy link
Member

johnugeorge commented Dec 18, 2018

Can you add one unit test in validation_test.go ?

@johnugeorge
Copy link
Member

/ok-to-test

@TravisBuddy

This comment has been minimized.

@DeliangFan DeliangFan force-pushed the validation-for-evaluator branch from 0d50293 to 18b7591 Compare December 19, 2018 03:03
@TravisBuddy

This comment has been minimized.

@DeliangFan DeliangFan force-pushed the validation-for-evaluator branch from 18b7591 to 54cb991 Compare December 19, 2018 03:28
@TravisBuddy

This comment has been minimized.

@DeliangFan DeliangFan force-pushed the validation-for-evaluator branch from 54cb991 to d443a2b Compare December 19, 2018 03:42
@TravisBuddy

This comment has been minimized.

@DeliangFan DeliangFan force-pushed the validation-for-evaluator branch from d443a2b to f8a3855 Compare December 19, 2018 05:00
Add validation for evaluator so that the number of evaluator
should no more than one.
@DeliangFan DeliangFan force-pushed the validation-for-evaluator branch from f8a3855 to c10b155 Compare December 19, 2018 05:05
@gaocegege
Copy link
Member

/retest

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DeliangFan
Copy link
Contributor Author

This fix #894

@gaocegege
Copy link
Member

Thanks for your contribution! I think the test should be passed. Let's wait.

@k8s-ci-robot k8s-ci-robot merged commit 6d70857 into kubeflow:master Dec 19, 2018
@DeliangFan DeliangFan deleted the validation-for-evaluator branch December 27, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants