-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for evaluator #895
Add validation for evaluator #895
Conversation
Hi @DeliangFan. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @johnugeorge |
Can you add one unit test in validation_test.go ? |
/ok-to-test |
4b54d9d
to
0d50293
Compare
This comment has been minimized.
This comment has been minimized.
0d50293
to
18b7591
Compare
This comment has been minimized.
This comment has been minimized.
18b7591
to
54cb991
Compare
This comment has been minimized.
This comment has been minimized.
54cb991
to
d443a2b
Compare
This comment has been minimized.
This comment has been minimized.
d443a2b
to
f8a3855
Compare
Add validation for evaluator so that the number of evaluator should no more than one.
f8a3855
to
c10b155
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This fix #894 |
Thanks for your contribution! I think the test should be passed. Let's wait. |
Add validation for evaluator so that the number of evaluator
should no more than 1.
Close #894
This change is