Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBM] update out-dated links in the docs #2260

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Conversation

adrian555
Copy link
Member

Part of efforts to resolve #2177, updated the out-dated links in the documents for Kubeflow running on IBM platforms.

@kubeflow-bot
Copy link

This change is Reviewable

Copy link
Contributor

@8bitmp3 8bitmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrian555 I've made a couple of suggestions, PTAL. Thank you

adrian555 and others added 2 commits October 6, 2020 12:16
Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>
Co-authored-by: 8bitmp3 <19637339+8bitmp3@users.noreply.github.com>
@8bitmp3
Copy link
Contributor

8bitmp3 commented Oct 6, 2020

Thank you @adrian555 !

It look like @animeshsingh is the only approver for IBM Cloud docs. And @adrian555 @shawnzhu and @Tomcli are the other reviewers (plus me). Maybe one of you wants to volunteer to become a backup approver?

/ok-to-test

@shawnzhu
Copy link
Member

shawnzhu commented Oct 7, 2020

/lgtm

@animeshsingh
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1216419 into kubeflow:master Oct 7, 2020
@8bitmp3
Copy link
Contributor

8bitmp3 commented Oct 7, 2020

Thank you @shawnzhu @adrian555 @animeshsingh 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] - "Outdated" files (38/250)
6 participants