Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update empty resources in Katib config #2799

Conversation

andreyvelich
Copy link
Member

Fixes: kubeflow/katib#1565.
Blocked by: kubeflow/katib#1564.

User can disable container CPU and Memory from the Katib config.

/cc @gaocegege @johnugeorge @sravi999 @RFMVasconcelos

@google-oss-robot
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: sravi999.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixes: kubeflow/katib#1565.
Blocked by: kubeflow/katib#1564.

User can disable container CPU and Memory from the Katib config.

/cc @gaocegege @johnugeorge @sravi999 @RFMVasconcelos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla bot added the cla: yes label Jun 29, 2021
@andreyvelich andreyvelich changed the title [WIP] Update empty resources in Katib config Update empty resources in Katib config Jun 29, 2021
@andreyvelich
Copy link
Member Author

This PR is ready to merge

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @gaocegege
/assign @johnugeorge
/assign @sravi999
/assign @RFMVasconcelos

@google-oss-robot
Copy link

@Arhell: GitHub didn't allow me to assign the following users: sravi999.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @gaocegege
/assign @johnugeorge
/assign @sravi999
/assign @RFMVasconcelos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for your contribution! 🎉 👍

@google-oss-robot google-oss-robot merged commit 97626a6 into kubeflow:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Disable CPU and Memory resources in Katib config
6 participants