Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pipeline root doc for kubeflow pipelines #2909

Merged
merged 10 commits into from
Sep 14, 2021

Conversation

capri-xiyue
Copy link
Contributor

added pipeline root doc for kubeflow pipelines

@capri-xiyue
Copy link
Contributor Author

@capri-xiyue
Copy link
Contributor Author

/assign @Bobgy

@google-oss-robot
Copy link

@capri-xiyue: GitHub didn't allow me to assign the following users: shuesc1.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @shuesc1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

content/en/docs/components/pipelines/pipeline-root.md Outdated Show resolved Hide resolved
content/en/docs/components/pipelines/pipeline-root.md Outdated Show resolved Hide resolved
content/en/docs/components/pipelines/pipeline-root.md Outdated Show resolved Hide resolved
content/en/docs/components/pipelines/pipeline-root.md Outdated Show resolved Hide resolved
content/en/docs/components/pipelines/pipeline-root.md Outdated Show resolved Hide resolved
content/en/docs/components/pipelines/pipeline-root.md Outdated Show resolved Hide resolved
content/en/docs/components/pipelines/pipeline-root.md Outdated Show resolved Hide resolved
content/en/docs/components/pipelines/pipeline-root.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @capri-xiyue!
This looks great overall! I left some nit pickings

content/en/docs/components/pipelines/pipeline-root.md Outdated Show resolved Hide resolved
content/en/docs/components/pipelines/pipeline-root.md Outdated Show resolved Hide resolved
content/en/docs/components/pipelines/pipeline-root.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor comments, getting better!

content/en/docs/components/pipelines/pipeline-root.md Outdated Show resolved Hide resolved
content/en/docs/components/pipelines/pipeline-root.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
The content looks great to me now.
I would defer to @shuesc1 for tech writing.

```shell
kubectl edit configMap kfp-launcher -n ${namespace}
```
This pipeline root will be the default pipeline root for all pipelines running in the Kubernetes Cluster unless you override it using one of the following options:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: cluster -> namespace too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@capri-xiyue
Copy link
Contributor Author

capri-xiyue commented Sep 13, 2021

Thank you!
The content looks great to me now.
I would defer to @shuesc1 for tech writing.

J Haymaker already reviewed it before you started to review.

@Bobgy
Copy link
Contributor

Bobgy commented Sep 14, 2021

Thanks a lot for updating the doc!
/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, capri-xiyue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 8ce6d0c into kubeflow:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants