Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KF 1.9 release: fix date and link to video #3835

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

tarilabs
Copy link
Member

  1. fix the release date,
    ref: https://github.com/kubeflow/manifests/releases/tag/v1.9.0
    as noticed by @thesuperzapper

  2. link to Kubeflow 1.9 Release Update youtube video

👉 if the PR is approved, I will update the video from Unlisted -> Published

@kubeflow/release-team @rimolive @StefanoFioravanzo @andreyvelich @hbelmiro @jbottum @juliusvonkohout

fix the release date,
ref: https://github.com/kubeflow/manifests/releases/tag/v1.9.0

link to Kubeflow 1.9 Release Update youtube video

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
@rimolive
Copy link
Member

Thank you Matteo for working in the release video!

/lgtm

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tarilabs.
/lgtm

@thesuperzapper
Copy link
Member

thesuperzapper commented Aug 19, 2024

@tarilabs In the interest of fixing the incorrect date while we wait for the video to be ready (we need to upload the video to the Kubeflow channel before we publish, not the Kubeflow Community), I have raised a separate PR to only fix the date:

Signed-off-by: Matteo Mortari <matteo.mortari@gmail.com>
@tarilabs
Copy link
Member Author

can this be approved, please? the video link is indeed referring to the video on the main Kubeflow channel.

unrelated, this:

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update @tarilabs!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0609b11 into kubeflow:master Sep 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants