Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add links to kubeflow 1.9 manifests #3837

Merged

Conversation

Al-Pragliola
Copy link
Contributor

This PR updates the "Kubeflow Manifests" section from page "Installing Kubeflow" with the new version and removes the 1.7 one to keep the same number of releases.

  1. added links to kubeflow 1.9 manifests
  2. removed links to kubeflow 1.7 manifests

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@google-oss-prow google-oss-prow bot requested review from alfsuse and knkski August 14, 2024 15:17
Copy link

Hi @Al-Pragliola. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@rimolive
Copy link
Member

/lgtm

@rimolive
Copy link
Member

@andreyvelich @terrytangyuan Would you mind approve this? We're updating the installation docs to point to 1.9 as the current release.

@terrytangyuan
Copy link
Member

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 6eaa2e8 into kubeflow:master Aug 21, 2024
6 checks passed
@Al-Pragliola Al-Pragliola deleted the chore/add-1-9-manifests-page branch September 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants