Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Generate vendor directories #10

Merged
merged 1 commit into from
May 17, 2019

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented May 16, 2019

Generated vendor directories via go mod vendor similar to what we've done for kubeflow/common (see discussion in kubeflow/common#28).


This change is Reviewable

@merlintang
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link

@merlintang: changing LGTM is restricted to assignees, and only kubeflow/xgboost-operator repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@merlintang
Copy link
Contributor

/approve

1 similar comment
@terrytangyuan
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: merlintang, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terrytangyuan
Copy link
Member Author

/lgtm

@k8s-ci-robot
Copy link

@terrytangyuan: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@terrytangyuan
Copy link
Member Author

terrytangyuan commented May 17, 2019

Handing over to you for lgtm:
/assign @johnugeorge @richardsliu

@johnugeorge
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 499ac78 into kubeflow:master May 17, 2019
@terrytangyuan terrytangyuan deleted the vendor-folder branch May 17, 2019 05:17
xfate123 pushed a commit to xfate123/xgboost-operator that referenced this pull request May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants