Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple webhooks to be configured #16

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

nashant
Copy link

@nashant nashant commented Mar 10, 2022

This allows the specification of any number of webhooks allowing for finer grained control over what resources are affected by the configuration

@vassilvk
Copy link
Member

Thank you @nashant.
Can you please summarize the use case you are trying to solve with this PR?
I see that this allows for multiple dragnet webhook configurations, but I am trying to understand what is the actual use case where you might need multiple simultaneous webhook configs.

@nashant
Copy link
Author

nashant commented Mar 10, 2022

So I don't want kubemod intercepting every pod creation, it's inefficient. I want to use object selectors to filter for some pods but not others.

@nashant
Copy link
Author

nashant commented Mar 10, 2022

I would also potentially like to be able to have my platform team in control of the helm release and allow developers to be able to create modrules, bounded by the constraints set in place by the webhooks

@vassilvk
Copy link
Member

Right.
The question is, can this be accomplished with a single webhook configuration.

@nashant nashant force-pushed the allow-multiple-webhooks-to-be-configured branch from 3c163b3 to 7597524 Compare March 11, 2022 07:07
@nashant nashant force-pushed the allow-multiple-webhooks-to-be-configured branch from 7597524 to 3e0f74e Compare March 11, 2022 07:08
@nashant
Copy link
Author

nashant commented Mar 11, 2022

In general? Yes. But kubemod is not replacing the caBundle in all the webhooks

@nashant
Copy link
Author

nashant commented Mar 11, 2022

But actually with a simple modification to kubemod-crt this will work. I'll do that now(ish)

@nashant
Copy link
Author

nashant commented Mar 11, 2022

That work is done

@nashant
Copy link
Author

nashant commented Mar 14, 2022

Solves #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants