split netpol cases #2322
Merged
split netpol cases #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangzujian
reviewed
Feb 10, 2023
Comment on lines
365
to
366
| k8s-netpol-e2e-legacy: | ||
| name: Kubernetes Network Policy E2E |
There was a problem hiding this comment.
Suggested change
| k8s-netpol-e2e-legacy: | |
| name: Kubernetes Network Policy E2E | |
| k8s-netpol-legacy-e2e: | |
| name: Kubernetes Network Policy Legacy E2E |
zhangzujian
reviewed
Feb 10, 2023
Makefile.e2e
Outdated
Comment on lines
8
to
9
| K8S_NETPOL_E2E_SKIP_LEGACY = "sig-network.*NetworkPolicyLegacy" | ||
| K8S_NETPOL_E2E_SKIP_NETPOL = "sig-network.*Netpol" |
There was a problem hiding this comment.
Suggested change
| K8S_NETPOL_E2E_SKIP_LEGACY = "sig-network.*NetworkPolicyLegacy" | |
| K8S_NETPOL_E2E_SKIP_NETPOL = "sig-network.*Netpol" | |
| K8S_NETPOL_E2E_SKIP = "sig-network.*NetworkPolicyLegacy" | |
| K8S_NETPOL_LEGACY_E2E_FOCUS = "sig-network.*NetworkPolicyLegacy" |
zhangzujian
reviewed
Feb 10, 2023
Makefile.e2e
Outdated
Comment on lines
52
to
57
| .PHONY: k8s-netpol-e2e-legacy | ||
| k8s-netpol-e2e-legacy: | ||
| go test ./test/e2e/k8s-network -c -o test/e2e/k8s-network/e2e.test | ||
| ./test/e2e/k8s-network/e2e.test --ginkgo.timeout=2h \ | ||
| $(call ginkgo_option,focus,$(K8S_NETPOL_E2E_FOCUS)) \ | ||
| $(call ginkgo_option,skip,$(K8S_NETPOL_E2E_SKIP_NETPOL)) |
There was a problem hiding this comment.
Suggested change
| .PHONY: k8s-netpol-e2e-legacy | |
| k8s-netpol-e2e-legacy: | |
| go test ./test/e2e/k8s-network -c -o test/e2e/k8s-network/e2e.test | |
| ./test/e2e/k8s-network/e2e.test --ginkgo.timeout=2h \ | |
| $(call ginkgo_option,focus,$(K8S_NETPOL_E2E_FOCUS)) \ | |
| $(call ginkgo_option,skip,$(K8S_NETPOL_E2E_SKIP_NETPOL)) | |
| .PHONY: k8s-netpol-legacy-e2e | |
| k8s-netpol-legacy-e2e: | |
| go test ./test/e2e/k8s-network -c -o test/e2e/k8s-network/e2e.test | |
| ./test/e2e/k8s-network/e2e.test --ginkgo.timeout=2h \ | |
| $(call ginkgo_option,focus,$(K8S_NETPOL_LEGACY_E2E_FOCUS)) |
zhangzujian
reviewed
Feb 10, 2023
Makefile.e2e
Outdated
| .PHONY: k8s-netpol-e2e | ||
| k8s-netpol-e2e: | ||
| go test ./test/e2e/k8s-network -c -o test/e2e/k8s-network/e2e.test | ||
| ./test/e2e/k8s-network/e2e.test --ginkgo.timeout=2h \ | ||
| $(call ginkgo_option,focus,$(K8S_NETPOL_E2E_FOCUS)) \ | ||
| $(call ginkgo_option,skip,$(K8S_NETPOL_E2E_SKIP)) | ||
| $(call ginkgo_option,skip,$(K8S_NETPOL_E2E_SKIP_LEGACY)) |
There was a problem hiding this comment.
Suggested change
| $(call ginkgo_option,skip,$(K8S_NETPOL_E2E_SKIP_LEGACY)) | |
| $(call ginkgo_option,skip,$(K8S_NETPOL_E2E_SKIP)) |
zhangzujian
reviewed
Feb 10, 2023
| @@ -362,6 +362,95 @@ jobs: | |||
| working-directory: ${{ env.E2E_DIR }} | |||
| run: make k8s-netpol-e2e | |||
|
|
|||
| k8s-netpol-legacy-e2e: | |||
| name: Kubernetes Network Policy E2E | |||
There was a problem hiding this comment.
Suggested change
| name: Kubernetes Network Policy E2E | |
| name: Kubernetes Network Policy Legacy E2E |
zhangzujian
reviewed
Feb 10, 2023
| @@ -1064,6 +1153,7 @@ jobs: | |||
| - build-centos-compile | |||
| - k8s-conformance-e2e | |||
| - k8s-netpol-e2e | |||
| - k8s-netpol-e2e-legacy | |||
There was a problem hiding this comment.
Suggested change
| - k8s-netpol-e2e-legacy | |
| - k8s-netpol-legacy-e2e |
There was a problem hiding this comment.
sorry for this small issue
zhangzujian
reviewed
Feb 10, 2023
| @@ -1064,6 +1153,7 @@ jobs: | |||
| - build-centos-compile | |||
| - k8s-conformance-e2e | |||
| - k8s-netpol-e2e | |||
| - k8s-netpol-legacy-e2e | |||
There was a problem hiding this comment.
Suggested change
| - k8s-netpol-legacy-e2e | |
| # - k8s-netpol-legacy-e2e |
Some e2e cases failed, we should comment this until the failure is resolved.
zhangzujian
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #2285