Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make webhook port configurable. #2631

Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix: make webhook port configurable. #2631

merged 1 commit into from
Apr 11, 2023

Conversation

xujunjie-cover
Copy link
Member

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #2630

@github-actions
Copy link
Contributor

  • The commit message is missing. It's important to have a clear and concise message that describes the changes made in the patch.
  • In line 46, pflag.Int returns a pointer to an integer, so it needs to be dereferenced in line 69 when assigning the value to Port.
  • There are no potential bugs or format errors in this patch.
  • There are no performance issues in this patch.
  • One way to improve this patch is to add error handling for the creation of the webhook server in case there are any issues with the port or certificate directory.

@oilbeater oilbeater requested a review from hongzhen-ma April 11, 2023 00:13
@hongzhen-ma hongzhen-ma merged commit ddf28fc into kubeovn:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongzhen-ma hongzhen-ma hongzhen-ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change webhook deploy to 8543，but the pod still use 8443
2 participants
@xujunjie-cover @hongzhen-ma