controller: fix DHCP MTU when the default network mode is underlay #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbb88888
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Which issue(s) this PR fixes:
Fixes #2930
WHAT
🤖 Generated by Copilot at 6616b9e
Refactor subnet controller and add default MTU constant. This change simplifies the code for updating DHCP options and ensures a consistent MTU value across the network.
🤖 Generated by Copilot at 6616b9e
HOW
🤖 Generated by Copilot at 6616b9e
updateSubnetDHCPOptionfunction to useDefaultMTUconstant and handlevlannetwork type (link)DefaultMTUconstant toutilpackage to store the default network interface MTU value (link)dhcpOptionsUUIDsvariable declaration using short syntax insubnet.go(link)