Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "nm not managed only in the change provide nic name case (#2754)" #2944

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Jun 15, 2023

This reverts commit c77f368.

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

Revert #2754

We still need to set underlay links unmanaged by NetworkManager since in some scenarios, some routes on the underlay link cannot be cleaned if the link is managed by NetworkManager.

Now it's safe to set the link unmanaged by NetworkManager, because:

  1. After the node reboots, start-ovs.sh removes all OVS bridges used in underlay networking;
  2. kube-ovn-cni waits ovs-vswitchd to be running before it starts.

WHAT

🤖 Generated by Copilot at e16f8d2

This pull request improves logging and network stability for the OVS daemon. It removes redundant log messages in init.go and prevents NetworkManager from managing the provider nic in ovs_linux.go.

🤖 Generated by Copilot at e16f8d2

Sing, O Muse, of the mighty pull request
That the skilled coder sent to his peers
To improve the network of the pods sublime
With OVS and the provider nic.

HOW

🤖 Generated by Copilot at e16f8d2

  • Remove redundant log messages that print the same information as the previous line (link, link) in init.go

@zhangzujian zhangzujian added bug Something isn't working need backport labels Jun 15, 2023
@zhangzujian zhangzujian requested a review from zbb88888 June 15, 2023 06:27
@zhangzujian zhangzujian marked this pull request as ready for review June 15, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants