Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choose subnet by pod's annotation in networkpolicy #2987

Merged
merged 1 commit into from
Jun 30, 2023
Merged

choose subnet by pod's annotation in networkpolicy #2987

merged 1 commit into from
Jun 30, 2023

Conversation

hongzhen-ma
Copy link
Collaborator

@hongzhen-ma hongzhen-ma commented Jun 27, 2023

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #2712

WHAT

🤖 Generated by Copilot at ace13b1

This pull request fixes a bug that causes duplicate ACL rules for gateway nodes by removing an unnecessary function call. It also moves a function definition to a more appropriate package to avoid circular dependencies.

🤖 Generated by Copilot at ace13b1

CreateNodeAcl moved
From ovs to controller
No more duplicate

HOW

🤖 Generated by Copilot at ace13b1

  • Remove unnecessary call to CreateGatewayAcl in handleAddOrUpdateSubnet function to fix duplicate ACL rules for gateway nodes (link)
  • Move CreateNodeAcl function from ovs package to controller package to improve code organization and avoid circular dependencies (link)

@oilbeater
Copy link
Collaborator

Need to rerun the networkpolicy related e2e.

And we can use allow-stateless to optimize the acl performance.

@hongzhen-ma hongzhen-ma changed the title delete acl creation for subnet gw in subnet's process choose subnet by pod's annotation in networkpolicy Jun 27, 2023
@zhangzujian
Copy link
Member

Rebase and force push to run the network policy e2e.

@hongzhen-ma hongzhen-ma merged commit af04530 into master Jun 30, 2023
64 checks passed
@hongzhen-ma hongzhen-ma deleted the np branch June 30, 2023 07:40
@hongzhen-ma
Copy link
Collaborator Author

已回合 release-1.11 分支

release-1.9 分支不存在该问题

zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Aug 15, 2023
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ACLs if no network policy exists
3 participants