fix .status.default when initializing the default vpc #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangzujian
force-pushed
the
fix-vpc-default
branch
from
701ad17
to
4c53f4a
Compare
oilbeater
approved these changes
Jul 28, 2023
zhangzujian
added a commit
to zhangzujian/kube-ovn
that referenced
this pull request
Jul 28, 2023
zhangzujian
added a commit
to zhangzujian/kube-ovn
that referenced
this pull request
Jul 28, 2023
zhangzujian
added a commit
to zhangzujian/kube-ovn
that referenced
this pull request
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Which issue(s) this PR fixes:
Fixes occasional incorrect field
.status.defaultof the default vpc.kube-ovn-controller updates status of cached vpc objects in function
initLoadBalancer(). In some scenarios field.status.defaultof the cached object isfalsewhile it's supposed to betrue.WHAT
🤖 Generated by Copilot at 701ad17
Fix controller crash and improve default VPC initialization. This pull request modifies
controller.goto handle the default VPC creation and update more robustly and efficiently.🤖 Generated by Copilot at 701ad17
HOW
🤖 Generated by Copilot at 701ad17
Runfunction (link)Runfunction, after the kube client is initialized (link)